Updating AWS security policy example #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to AWS, using a wildcard in the PassRole permission allows the action on multiple resources, what raises a security warning when creating the policy. Therefore, to be extra safe, we should add a condition, to limit its application only on EC2 resources.
snay2
suggested changes
Nov 3, 2022
| ], | ||
| "Condition": { | ||
| "StringEquals": { | ||
| "iam:PassedToService": [ |
There was a problem hiding this comment.
Since this Condition applies only to iam:PassRole, I recommend we split it out into its own Statement to make the distinction clearer. Whether it works this way or not, having separate Statements for the two kinds of IAM actions will be easier to read.
|
I updated the PR and the commit ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to AWS, using a wildcard in the PassRole permission allows the action on multiple resources, what raises a security warning when creating the policy.
Source: Security Warning – Pass role with star in resource.
Therefore, to be extra safe, we should add a condition, to limit its application only on EC2 resources.
In order to test this modification, currently, I use the plugin with the given policy without any issues.
Link to relevant issues in GitHub or Jira(Not appliable)Link to relevant pull requests, esp. upstream and downstream changes(Not appliable)Ensure you have provided tests - that demonstrates feature works or fixes the issue(Not appliable)