Skip to content

EOL JSR 305 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023
Merged

EOL JSR 305 #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/hudson/plugins/build_timeout/global/GlobalTimeOutRunListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import hudson.model.*;
import hudson.model.listeners.RunListener;

import javax.annotation.Nonnull;
import edu.umd.cs.findbugs.annotations.NonNull;
import javax.inject.Inject;
import javax.inject.Singleton;
import java.io.IOException;
Expand Down Expand Up @@ -47,7 +47,7 @@ public Environment setUpEnvironment(AbstractBuild build, Launcher launcher, Buil
}

@Override
public void onCompleted(Run<?, ?> run, @Nonnull TaskListener listener) {
public void onCompleted(Run<?, ?> run, @NonNull TaskListener listener) {
store.cancel(run.getExternalizableId());
}
}
8 changes: 4 additions & 4 deletions src/test/java/hudson/plugins/build_timeout/global/TimeOutTaskTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import org.mockito.junit.MockitoRule;
import org.mockito.quality.Strictness;

import javax.annotation.Nonnull;
import edu.umd.cs.findbugs.annotations.NonNull;
import java.time.Duration;

import static org.junit.Assert.assertFalse;
Expand Down Expand Up @@ -80,7 +80,7 @@ private static class TestOp extends BuildTimeOutOperation {
boolean performed = false;

@Override
public boolean perform(@Nonnull AbstractBuild<?, ?> build, @Nonnull BuildListener listener, long effectiveTimeout) {
public boolean perform(@NonNull AbstractBuild<?, ?> build, @NonNull BuildListener listener, long effectiveTimeout) {
performed = true;
return true;
}
Expand All @@ -90,7 +90,7 @@ private static class FailsOp extends BuildTimeOutOperation {
boolean performed = false;

@Override
public boolean perform(@Nonnull AbstractBuild<?, ?> build, @Nonnull BuildListener listener, long effectiveTimeout) {
public boolean perform(@NonNull AbstractBuild<?, ?> build, @NonNull BuildListener listener, long effectiveTimeout) {
performed = true;
return false;
}
Expand All @@ -100,7 +100,7 @@ private static class ThrowsOp extends BuildTimeOutOperation {
boolean performed = false;

@Override
public boolean perform(@Nonnull AbstractBuild<?, ?> build, @Nonnull BuildListener listener, long effectiveTimeout) {
public boolean perform(@NonNull AbstractBuild<?, ?> build, @NonNull BuildListener listener, long effectiveTimeout) {
performed = true;
throw new RuntimeException("bad");
}
Expand Down