fix some defects #178
Merged
fix some defects #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
=============================================
+ Coverage 99.21% 100.00% +0.78%
- Complexity 135 137 +2
=============================================
Files 29 29
Lines 256 263 +7
Branches 18 18
=============================================
+ Hits 254 263 +9
+ Misses 1 0 -1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
damianszczepanik
approved these changes
Mar 31, 2025
- mark overriden methods deprecated when base is deprecated - use java.nio.file.Files#delete instead of file#delete and adapt tests accordingly using static mocking
theKBro
force-pushed
the
fixSonarqubeDefects
branch
from
89ad48e to
4fd743b
Compare
|
I hope this is ok now |
damianszczepanik
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing some defects
as required in #175