Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobcacher to the managed set #4704

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

jonesbusy
Copy link
Contributor

Fix #4287

Testing done

PLUGINS=jobcacher TEST=InjectedTest bash local-test.sh

Docker test should be skipped by https://github.com/jenkinsci/jobcacher-plugin/pull/375/files

Possible now 2.479 is on the bottom line

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy requested a review from a team as a code owner March 14, 2025 10:57
@basil basil added the full-test Test all LTS lines in this PR and do not halt upon first error. label Mar 14, 2025
@jonesbusy
Copy link
Contributor Author

super green! Thanks @krisstern

@krisstern
Copy link
Member

You are welcome @jonesbusy!

@krisstern krisstern merged commit 264d787 into jenkinsci:master Mar 14, 2025
778 checks passed
@@ -45,6 +45,10 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>authorize-project</artifactId>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>jobcacher</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this should have been in test scope unless it is needed to compile the sample plugin. I'll fix this in one of my next few PRs, so this comment is just for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Job Cacher (jobcacher) to the managed set
3 participants