BitbucketTagSCMHead does not receive an annotated tag date #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfalco79
force-pushed
the
feature/datacenter-tag-timestamp
branch
from
85935c8 to
e1ac0b1
Compare
…r webhook processor instead of the annotated tag timestamp or using the referred commit timestamp. This is archived perforing a remote call to get missing details in the event payload, unfortunately there are no real example to implement a different strategy.
nfalco79
force-pushed
the
feature/datacenter-tag-timestamp
branch
from
e1ac0b1 to
8acf56f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -80,6 +85,27 @@ | |||
| .isEqualTo(new BranchSCMHead("main")); | |||
| } | |||
|
|
|||
| @WithJenkins | |||
| @Test | |||
| void test_tag_timestamp(JenkinsRule rule) throws Exception { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
To fix the problem, we should remove the unused parameter JenkinsRule rule from the test_tag_timestamp method. This will simplify the method signature and eliminate the unnecessary parameter, adhering to best practices.
- Remove the
JenkinsRule ruleparameter from thetest_tag_timestampmethod. - Ensure that the method still functions correctly without this parameter.
Suggested changeset
1
src/test/java/com/cloudbees/jenkins/plugins/bitbucket/hooks/NativeServerPushHookProcessorTest.java
| @@ -89,3 +89,3 @@ | ||
| @Test | ||
| void test_tag_timestamp(JenkinsRule rule) throws Exception { | ||
| void test_tag_timestamp() throws Exception { | ||
| sut.process(HookEventType.SERVER_REFS_CHANGED, loadResource("native/tagPayload.json"), BitbucketType.SERVER, "origin", SERVER_URL); |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the timestamp in BitbucketTagSCMHead valued with 0 in NativeServer webhook processor instead of the annotated tag timestamp or using the referred commit timestamp.
This is archived perforing a remote call to get missing details in the event payload, unfortunately there are no real example to implement a different strategy.
Fix #642