Skip to content

Added condition for 403 HTTP Status #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

alexanderrtaylor
Copy link
Contributor

Added a condition for Issue 273 so that permisisons issues dont break your branch indexing completely

The goal is to fix #273 (comment) where the branch indexing was broken when the user didnt have access to a specific branch. Also it helps if there is any situation where a auth failure happens with something like API limits

Your checklist for this pull request

  • [ ✅] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • [ ✅] Ensure that the pull request title represents the desired changelog entry
  • [ ✅ ] Please describe what you did
  • [ ✅ ] Link to relevant issues in GitHub or in Jenkins JIRA
  • [ ❌ ] Did you provide a test-case? That demonstrates feature works or fixes the issue. - Currently there is no implementation for HTTP status checks in the test code which means a large wiremock implementation needs to be done (most likely) and that is going to require much more time investment. I would like to do it later though.

Alex Taylor added 2 commits January 22, 2020 13:44
Added a condition for Issue 273 so that permisisons issues dont break your branch indexing completely
"Avoid calling toString() on String objects; this is unnecessary."

My bad I thought it was some other type
@jetersen jetersen changed the title [273] Added condition for 403 HTTP Status Added condition for 403 HTTP Status Jan 28, 2020
@jetersen jetersen merged commit 4baa6d7 into jenkinsci:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BitbucketCloudApiClient doesn't handle SC_FORBIDDEN
2 participants