add OAuth authentication

[kurddt]

Your checklist for this pull request

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or in Jenkins JIRA
• Link to relevant pull requests, esp. upstream and downstream changes
• Did you provide a test-case? That demonstrates feature works or fixes the issue.

I tried to revive #69 by re-basing on master and adapting the code to the changes that was made since especially #101 .

The functionality is working, but the normal user/password is broken. I don't really have any idea how to make both work so any suggestion would be greatly appreciated

[jetersen]

Thanks for picking up the effort :)

[kurddt]

@Casz Any idea on whom could help me / give me some pointer on how to support both OAuth and user/password credentials ?

[kurddt]

I made a test case for the OAuth authenticator but it requires an access to bitbucket.org and to generate a OAuth key/secret so I didn't include it in the PR

[jetersen]

I'd appreciate if you could avoid force pushing 😓

[kurddt]

Sure. Any idea why the integration failed on jenkins ?

[jetersen]

@kurddt I'd guess ci.jenkins.io is having a bad day :)

https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fbitbucket-branch-source-plugin/detail/PR-262/9/tests

[kurddt]

@Casz Is there any way to re-start it ?

[jetersen]

LGTM one nit pick

[jetersen]

Problem atm is both Oauth and username password uses the same base class StandardUsernamePasswordCredentials

[jetersen]

I would love some documentation on how to set this up.
Cause I will need the docs to test this 😓

[kurddt]

I could write a small documentation, about the usage of this feature just tell me in which format and/or where you want want it.

Concerning, the base class. Even if they use the same base class, the class can detect if the credentials match a API key and secret. The other solution would be to introduce an other type of credentials in Jenkins but I had no idea how to do so.

[jetersen]

We have section for that on the user guide: https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/master/docs/USER_GUIDE.adoc

[jetersen]

link to see current commit author: https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/262/commits/13ca375e745844106dba199de36ac202b9959d9f.patch

@kurddt
You might want to set up an email alias on your GitHub account 🥇
https://help.github.com/articles/adding-an-email-address-to-your-github-account/

Or look into fixing your git user.email config 😅
https://help.github.com/articles/setting-your-commit-email-address-in-git
then you would need to amend your commits: https://stackoverflow.com/a/3042512
after changing author

to get proper credit for your commits 🏆

[kurddt]

@Casz Thanks, I made a new clone of the repo but forgot to change the local git config 😅

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[cblakkan]

It would be awesome to have this functionality supported, did this go stale?

[jetersen]

hopefully #299 should remove the blocker

[jetersen]

Perhaps a good idea to cache the token, I assume it has a validity time 🤔

[jetersen]

I think we can move forward without caching. Perhaps a future PR.