-
Notifications
You must be signed in to change notification settings - Fork 356
[JENKINS-57516] - Support tag creation on tag push #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1ffd116
to
cefd317
Compare
Setup Bitbucket server and jenkins server using docker container, and is able to verify that the tags can be instantly created once dev ran |
@sheldonrong |
cefd317
to
09c02e1
Compare
@Casz Thanks for reminding, updated the commit, and should be good now :) |
09c02e1
to
808fc51
Compare
@Casz looks like the continuous-integration/jenkins/pr-merge is stuck :) |
@Casz any updates on this one? |
Great if someone could push this forward. This is the only feature missing for us in our current CI/CD pipeline :) |
Thx Joseph. Will test it as soon as I can :) |
@@ -137,23 +138,29 @@ protected BitbucketServerRepository getRepository() { | |||
return result; | |||
} | |||
|
|||
private void addBranches(BitbucketSCMSource src, Map<SCMHead, SCMRevision> result) { | |||
private void addBranchesAndTags(BitbucketSCMSource src, Map<SCMHead, SCMRevision> result) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test covering this new logic would be more than welcome.
Verified that this works. Thanks a lot. Hopefully I can provide a PR for tag delete events :) |
Hoping someone can see this and respond -- it seems like this fixed an issue where once the Webhook was setup in Bitbucket to notify on Tag Created events, this was needed to process the event notification... Am I missing something, or is there still not logic to automatically include |
Able to detect a tag creation from the Bitbucket PushHead Event and automatically create tags in Jenkins. This allows the workflow to build projects when tagging and/or pushing a commit.
This changeset adds a tag detection branch logic in the NativeServerPushHookProcessor.HeadEvent's heads function.
Your checklist for this pull request