JENKINS-47867 Add WebhookConfigurationTrait #194
Conversation
- Adds a trait to allow setting of the committersToIgnore value - Adds unit tests for setting of the value - Adds a property accessor to the WebhookConfiguration for testing - Adds resource definitions to allow setting in the UI
- rename tests without underscores - remove unused import
|
👀 |
src/main/resources/com/cloudbees/jenkins/plugins/bitbucket/WebhookConfigurationTrait/help.html
Show resolved
Hide resolved
|
looks like the window node was offline in that last test run, or generally had trouble with the connection. Is there a way to re-trigger the test run without a code push? |
|
what I usually do is just an empty commit: |
|
@Casz much easier is to close the PR, wait 30 seconds, open it again. Boom rebuild without extra commits |
|
Ah, like the trick with the close/re-open triggering the rebuild. Happy to rebase to compact the extra commits; it doesn't look like you squash on merge. |
|
No need @redfive I usually use squashing as it keeps the branch graph clean. |
|
What's left in the process for this one? Would love to get this landed so I can roll out an official plugin. |
|
Bump to keep this on radar. Any chance of a review this week? Thanks! |
|
Personally I think it would be better if this functionality could live in the plugin that is the bitbucket webhook receiver... however as I suspect that would result in a circular dependency, it is probably OK-ish to add it here. |
|
@stephenc which plugin is that? I see all the webhook registration and listener code in this plugin. And I don't see another plugin that is obviously the BB Webhook Receiver. |
|
What can I do to help push this through? It's been up for review for almost a month. :-( |
|
Thanks @Casz !!! |
|
@redfive your welcome 😊 |
Your checklist for this pull request
Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
[x ] Please describe what you did
[x ] Link to relevant GitHub issues or pull requests
Link to relevant Jenkins JIRA issues
[x ] Did you provide a test-case? That demonstrates feature works or fixes the issue.
Description
Add a WebhookConfigurationTrait to allow setting of the committersToIgnore value of the WebhookConfiguration class. This makes it possible to set and persist the value of field for the Bitbucket Webhook. Without this exposure there is no way to set and maintain the setting on the Webhook as the current implementation does not set it, and always overwrites what is set on the server (since it's always different).
Addresses this Jira issue:
https://issues.jenkins-ci.org/browse/JENKINS-47867
Previous PR that added some of the required plumbing:
#77