Add a new trait to discard all tags with creation date older than the configured days #1017
Conversation
… configured days.
|
@nfalco79 Added filter trait for tags similar to DiscardOldBranchTrait, but was able to use |
| * Discard all tags with creation date older than the configured days. | ||
| * | ||
| * @author Madis Parn | ||
| * @since ??? |
There was a problem hiding this comment.
remove or write current snapshot version 936.0.0
| } | ||
| } | ||
|
|
||
| public static final class ExcludeOldSCMTag extends SCMHeadPrefilter { |
There was a problem hiding this comment.
any reason why SCMHeadPrefilter instead of SCMHeadFilter?
There was a problem hiding this comment.
IIUC, SCMHeadPrefilter is the right choice here because ExcludeOldSCMTag does not make remote requests. GitTagSCMHead.getTimestamp() simply returns the value of a field. SCMSourceRequest.isExcluded evaluates SCMHeadPrefilter before SCMHeadFilter, so if ExcludeOldSCMTag decides to exclude the tag, then no SCMHeadFilter will be evaluated and their remote requests will be avoided.
|
|
||
| @Override | ||
| public boolean isExcluded(@NonNull SCMSource source, @NonNull SCMHead head) { | ||
| if (!(head instanceof BitbucketTagSCMHead tagHead)) { |
There was a problem hiding this comment.
use GitTagSCMHead instead of BitbucketTagSCMHead
| /* | ||
| * The MIT License | ||
| * | ||
| * Copyright (c) 2025, CloudBees, Inc. |
| private final long expiryMs; | ||
|
|
||
| public ExcludeOldSCMTag(int keepForDays) { | ||
| this.expiryMs = ZonedDateTime.now().minusDays(keepForDays) |
| } | ||
|
|
||
| @Test | ||
| void verify_that_branch_is_excluded_if_expired() { |
There was a problem hiding this comment.
Using a natural language? what would you mean?
There was a problem hiding this comment.
this PR is about excluding tags, not branches, as currently indicated by the test method name
| if (!(head instanceof BitbucketTagSCMHead tagHead)) { | ||
| return false; | ||
| } | ||
| return tagHead.getTimestamp() < expiryMs; |
There was a problem hiding this comment.
when tagHead.getTimestamp() is 0 do not exclude
Your checklist for this pull request