Skip to content

[JENKINS-74234] Remove unused Jelly view #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

yaroslavafenkin
Copy link

https://issues.jenkins.io/browse/JENKINS-74234

Testing done

This snipped in present inline in

<div align="right">
<span class="yui-button yui-push-button yui-button">
<button id="validateJiraIssueConfig" type="button" onClick="validateFieldConfings()">Validate Fields</button>
</span>
<l:icon class="icon-help icon-sm" style="cursor:pointer" onclick="hideshow(document.getElementById('helpValidateJiraIssueConfig'))"/>
<img src="${imagesURL}/spinner.gif" style="display:none" id="jiraSpinner"/>
</div>
<div id="helpValidateJiraIssueConfig" class="help" style="display:none">
<p>Since Jira Rest API does not offer a way to validate field values, the plugin will try to create and delete an issue
and it will print the errors (if any).</p>
<p><b>WARNING: The user configured in the global configuration page needs to have permission to delete issues.</b></p>
<p>Variables will not be expanded.</p>
</div>

I haven't found any inclusions of helpValidateConfigButton.jelly via st:include, so I guess this is a dead code.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@yaroslavafenkin yaroslavafenkin requested a review from a team as a code owner November 13, 2024 16:59
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@basil basil added the removed label Nov 13, 2024
@basil basil changed the title [JENKINS-74234] Remove unused jelly view [JENKINS-74234] Remove unused Jelly view Nov 13, 2024
@basil basil merged commit 718fe35 into jenkinsci:master Nov 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants