Skip to content

fix #143 java compiler warning #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix #143 java compiler warning #171

merged 2 commits into from
Oct 24, 2024

Conversation

chcg
Copy link

@chcg chcg commented Oct 23, 2024

fixes #143

08:24:17 [WARNING] /home/jenkins/agent/workspace/TestResultReporter-plugin_master/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/config/SelectableArrayFields.java:[169,60] non-varargs call of varargs method with inexact argument type for last parameter;
08:24:17 cast to java.lang.Object for a varargs call
08:24:17 cast to java.lang.Object[] for a non-varargs call and to suppress this warning

Maybe still of interest to analyse:

08:24:17 [INFO] /home/jenkins/agent/workspace/TestResultReporter-plugin_master/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/JiraTestAction.java: Some input files use or override a deprecated API.
08:24:17 [INFO] /home/jenkins/agent/workspace/TestResultReporter-plugin_master/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/JiraTestAction.java: Recompile with -Xlint:deprecation for details.
08:24:17 [INFO] /home/jenkins/agent/workspace/TestResultReporter-plugin_master/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/JiraTestDataPublisher.java: Some input files use unchecked or unsafe operations.
08:24:17 [INFO] /home/jenkins/agent/workspace/TestResultReporter-plugin_master/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/JiraTestDataPublisher.java: Recompile with -Xlint:unchecked for details.

Testing done

See https://github.com/jenkinsci/JiraTestResultReporter-plugin/pull/171/checks?check_run_id=31937212888
Security Scan seems to fail due to some other reason (maven download)

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

08:24:17  [WARNING] /home/jenkins/agent/workspace/TestResultReporter-plugin_master/src/main/java/org/jenkinsci/plugins/JiraTestResultReporter/config/SelectableArrayFields.java:[169,60] non-varargs call of varargs method with inexact argument type for last parameter;
08:24:17    cast to java.lang.Object for a varargs call
08:24:17    cast to java.lang.Object[] for a non-varargs call and to suppress this warning
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion.

…fig/SelectableArrayFields.java

Co-authored-by: Basil Crow <[email protected]>
@chcg chcg mentioned this pull request Oct 24, 2024
6 tasks
@basil basil added the internal label Oct 24, 2024
@basil basil merged commit 5786a59 into jenkinsci:master Oct 24, 2024
17 checks passed
@chcg chcg deleted the issue_143 branch October 24, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check warnings
2 participants