Added bearer token support #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added global option for usage of password field for Bearer Token as described in jenkinsci#140, similar to jira plugin
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| private static final String AUTHORIZATION_HEADER = "Authorization"; | ||
|
|
||
| private final String token; |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Plaintext password storage Warning
There was a problem hiding this comment.
Token here is transferred to jira server. The input therefore comes from the password field which is stored to disk.
|
@basil Is this PR ok to be integrated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
Testing done
Tested with Jenkins https://www.jenkins.io/changelog-stable/#v2.462.2 and none cloud aka enterprise Jira. Change should be backwards compatible and the default behaviour is not to use the bearer token but basic auth as before.
Submitter checklist