Skip to content

Fix on parallel branches bug #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

imonteroperez
Copy link

@imonteroperez imonteroperez commented Jan 16, 2024

Highlights

  • Use of parallel in pipelines with the JiraTestDataResultReporter publisher makes this to provide repeated results on the /testReport due to multiple generations of duplicated JiraTestAction entities
  • Then badge.jelly renders all of them for all the parallel branches
  • Main reason is the generation of a JiraTestData for each branch execution. Each build should have only one JiraTestData to provide.
  • This PR fixes this issue by maintaining in a in-memory registry all the mappings between JiraTestData and build URLs.
  • Tested locally
  • Before the PR
    Captura de pantalla de 2024-01-16 15-28-22
  • After the PR
    Captura de pantalla de 2024-01-18 12-27-15

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@imonteroperez imonteroperez marked this pull request as draft January 16, 2024 12:17
@imonteroperez
Copy link
Author

Detected a bug, converted to draft to fix it

@imonteroperez imonteroperez force-pushed the parallel-bugfix branch 2 times, most recently from 07044c0 to a98e91e Compare January 18, 2024 11:25
@imonteroperez imonteroperez marked this pull request as ready for review January 18, 2024 11:28
@imonteroperez imonteroperez merged commit 857a054 into jenkinsci:master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants