-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: replace "master" with "main" #7841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: replace "master" with "main" #7841
Conversation
updated the branch . |
This seems like a lot of work with many, many opportunities for issues, without me being confident that @biru-codeastromer is ready for the weeks or months of issues that will result from the change. Have you checked the other documentation generation locations that contribute to the jenkins.io site, like the backend extension indexer and the pipeline steps documentation generator? Have you investigated the changelog generator tooling to confirm that it will continue to submit pull requests that are targeting the correct branch? |
Hi Sir , Thanks for your constructive feedback! I completely understand that such a broad change comes with long-term implications, and I appreciate your insights and concerns. Regarding your concerns: I thought it would be better to raise a PR for improvements, so I prepared this as a draft to initiate discussions and track areas that need further research. Since there’s still work and investigation left, you can keep this PR in draft mode while I continue my research. If you believe this is doable for me, I’d be happy to continue working on it. Thanks again Sir for your valuable feedback! Much appreaciated |
The list of files in #7126 also includes the issue templates, I think they should be included in the PR. |
Thanks for the feedback ! Will be including them in the PR now . |
I have added ! |
this file : "jenkins.io/updatecli/values.github-action.yaml" too has it as :
|
Hi @biru-codeastromer, is this intended to just be the jenkins.io github repo documentation update, or would the jenkins.io documentation pages be updated in this PR as well? I ask because when reviewing the documentation on jenkins.io, there are several uses of the master URL that would be updated here. If that will be a separate PR, please let me know and I'm happy to help gather all the usages and create a draft PR to make the accompanying updates. |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
for my latest pr , the conflicts came here will be fixing it now |
done ! |
Fixes #7126
Description:
This PR replaces all instances of
master
withmain
in the codebase, documentation, and GitHub workflows.Changes include:
Please review and let me for further improvements !