-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trust proxy ssl to forward session cookie #1193
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
==========================================
- Coverage 86.67% 86.64% -0.04%
==========================================
Files 87 87
Lines 5876 5877 +1
==========================================
- Hits 5093 5092 -1
- Misses 783 785 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just 2 small changes
Co-authored-by: arran-standish <[email protected]>
Co-authored-by: arran-standish <[email protected]>
Motivation
I was deploying OpenHIM for Indonesia on Google Cloud Run. OpenHIM is served behing a proxy that issues the SSL.
It was impossible to connect through OpenHIM console. When checking the logs I found the following error : "Error: Cannot send secure cookie over unencrypted connection"
Basically, you cannot set "secure=true" for the cookie and then serve it in HTTP. For that we needed that option to trust that the proxy.
Check : koajs/koa#974
NOTE : This should be tested in platform.