Skip to content

BasicNetwork.reset() vs basicNetwork.reset(int) #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pijusn opened this issue Sep 13, 2014 · 2 comments
Closed

BasicNetwork.reset() vs basicNetwork.reset(int) #181

pijusn opened this issue Sep 13, 2014 · 2 comments
Labels
Milestone

Comments

@pijusn
Copy link

pijusn commented Sep 13, 2014

I have noticed BasicNetwork has two reset methods:

public void reset() {
    getRandomizer().randomize(this);
}

And one with a seed variable:

public void reset(final int seed) {
    Randomizer randomizer = getRandomizer();
    randomizer.randomize(this);
}

However, seed variable is not used and they do the same thing. It does not seem right. It seems like the second method is supposed to initialise randomiser with given weights.

@jeffheaton
Copy link
Owner

Thanks, yes I agree that is incorrect.

@jeffheaton jeffheaton added this to the Encog 3.3 milestone Sep 23, 2014
@jeffheaton jeffheaton added the Bug label Sep 23, 2014
@jeffheaton jeffheaton modified the milestones: Encog v3.3, Encog 3.3 Sep 23, 2014
@jeffheaton
Copy link
Owner

Just checked in a fix for this. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants