-
Notifications
You must be signed in to change notification settings - Fork 6
rijndael #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
rijndael #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @doomedraven, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request introduces a new decryptor, ConfigDecryptorRijndael
, to handle RAT payloads that use Rijndael (AES) encryption in CBC mode. The new decryptor is added to the list of supported decryptors and is designed to extract the AES key from the payload using specific patterns. It includes methods for deriving the key, decrypting ciphertext, and handling base64-encoded strings. The code also handles potential padding issues during decryption.
Highlights
- New Decryptor: Adds
ConfigDecryptorRijndael
to decrypt configurations encrypted with Rijndael (AES) in CBC mode. - Key Extraction: Implements methods to extract the AES key from the payload using MD5 hash patterns and RVAs (Relative Virtual Addresses).
- Decryption Logic: Includes decryption logic with padding and unpadding to handle different ciphertext formats.
- Integration: Integrates the new decryptor into the existing framework by adding it to the list of supported decryptors.
Changelog
- src/rat_king_parser/config_parser/utils/decryptors/init.py
- Imported
ConfigDecryptorRijndael
. - Added
ConfigDecryptorRijndael
to the list of exported classes. - Added
ConfigDecryptorRijndael
to theSUPPORTED_DECRYPTORS
list.
- Imported
- src/rat_king_parser/config_parser/utils/decryptors/config_decryptor_rijndael.py
- Created a new file
config_decryptor_rijndael.py
containing theConfigDecryptorRijndael
class. - Implemented methods for key derivation, ciphertext decryption, and RVA extraction.
- Included error handling for incompatible decryptors and padding issues.
- Created a new file
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A cipher's dance, a hidden key,
Rijndael's depths, for all to see.
With patterns found,
The secrets unbound,
Payload's whispers, now carefree.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a new decryptor, ConfigDecryptorRijndael
, for handling RAT payloads that use Rijndael (AES) encryption in CBC mode. The implementation includes necessary imports, pattern matching for key extraction, and decryption logic. The new decryptor is also integrated into the existing framework by adding it to the list of supported decryptors. Overall, the code appears well-structured and addresses the intended functionality.
Merge Readiness
The pull request introduces a new decryptor and integrates it into the existing framework. Given the nature of the changes, it's important to ensure that the new decryptor is thoroughly tested and doesn't introduce any regressions. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. The pull request appears ready to be merged, pending thorough testing and approval from other reviewers.
src/rat_king_parser/config_parser/utils/decryptors/config_decryptor_rijndael.py
Outdated
Show resolved
Hide resolved
src/rat_king_parser/config_parser/utils/decryptors/config_decryptor_rijndael.py
Outdated
Show resolved
Hide resolved
src/rat_king_parser/config_parser/utils/decryptors/config_decryptor_rijndael.py
Outdated
Show resolved
Hide resolved
src/rat_king_parser/config_parser/utils/decryptors/config_decryptor_rijndael.py
Show resolved
Hide resolved
…yptor_rijndael.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.