Skip to content

docs: add renovate example #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zeitlinger
Copy link
Contributor

No description provided.

@zeitlinger zeitlinger requested a review from jdx as a code owner July 21, 2025 13:35
@zeitlinger zeitlinger changed the title add renovate example docs: add renovate example Jul 21, 2025
@risu729
Copy link
Contributor

risu729 commented Jul 21, 2025

I think we should use jsonata instead of regex.
I have the config in https://github.com/risu729/renovate-config/blob/352c89acc8b35ec6013136ecf0aee8d6763f6db9/src/default.json5#L63-L79

@zeitlinger
Copy link
Contributor Author

I think we should use jsonata instead of regex. I have the config in https://github.com/risu729/renovate-config/blob/352c89acc8b35ec6013136ecf0aee8d6763f6db9/src/default.json5#L63-L79

jsonata is probably less familiar for most people - but it's more resilient - e.g. if you change the order of properties.

Can you

@risu729
Copy link
Contributor

risu729 commented Jul 22, 2025

extend the example to support sha256?

Thanks, I didn't know about github-release-attachments. I'll have a look.

ideally create a PR on renovate to have this enabled by default?

I don't think they will accept the support for third-party actions. Do you know something related to the policy?

@zeitlinger
Copy link
Contributor Author

I don't think they will accept the support for third-party actions. Do you know something related to the policy?

how is this different to the support of the other gh actions in the same file that I linked?

@risu729
Copy link
Contributor

risu729 commented Jul 22, 2025

how is this different to the support of the other gh actions in the same file that I linked?

packageName: `actions/${action}-versions`

This means only the official actions are supported.
actions/go-versions, actions/node-versions, and actions/python-versions.

@zeitlinger
Copy link
Contributor Author

The comment in the PR is "Not covered yet because they use different datasources/packageNames", which sounds like it could be added.

https://github.com/renovatebot/renovate/blob/3e0d35a960c4fdb36b63d86aa45a130c1fb10d3d/lib/modules/manager/github-actions/extract.ts#L181

@risu729
Copy link
Contributor

risu729 commented Jul 22, 2025

I've found that only digests for small assets (less than 5kiB) are supported, so mise binaries cannot be updated.

https://github.com/renovatebot/renovate/blob/3e0d35a960c4fdb36b63d86aa45a130c1fb10d3d/lib/modules/datasource/github-release-attachments/index.ts#L64-L66

Have you tested the Renovate config already? If it was working, I should've read the code wrong.

Never mind, I was wrong. It was just looking for the checksum file.

Also, we can extend the support by using GitHub API, as they now have the digest in the API response. I'll open a PR later.

@risu729
Copy link
Contributor

risu729 commented Jul 22, 2025

The comment in the PR is "Not covered yet because they use different datasources/packageNames", which sounds like it could be added.

https://github.com/renovatebot/renovate/blob/3e0d35a960c4fdb36b63d86aa45a130c1fb10d3d/lib/modules/manager/github-actions/extract.ts#L181

Hmm, they're also the official actions.
However, they don't say it's limited to the official actions in the docs, so could you open a discussion there if you're interested in it?
I'm happy to work on it if they'll accept the change.

@zeitlinger
Copy link
Contributor Author

Hmm, they're also the official actions. However, they don't say it's limited to the official actions in the docs, so could you open a discussion there if you're interested in it? I'm happy to work on it if they'll accept the change.

Great - I've created renovatebot/renovate#37106 to discuss it

@zeitlinger
Copy link
Contributor Author

Also, we can extend the support by using GitHub API, as they now have the digest in the API response. I'll open a PR later.

I think it's already using the API for the checksum - at least it looked that way from the error messages while I was debugging

@risu729
Copy link
Contributor

risu729 commented Jul 22, 2025

Great - I've created renovatebot/renovate#37106 to discuss it

Thank you!

I think it's already using the API for the checksum - at least it looked that way from the error messages while I was debugging

I don't think so, as it's not updated recently.

@risu729
Copy link
Contributor

risu729 commented Jul 25, 2025

I updated my Renovate config risu729/renovate-config#835.
I think it would work, but I'll wait for a Renovate PR to be opened.

For the upstream Renovate, since they haven't replied yet, I'm thinking of creating a PR to add a custom manager preset.
They already have a generic GitHub Actions _VERSION updating preset.
https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants