Skip to content

feat(calendar): 添加自定义周起始日配置 #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 17, 2022

Conversation

thx125
Copy link
Contributor

@thx125 thx125 commented Nov 7, 2022

这个 PR 做了什么? (简要描述所做更改)
日历组件添加自定义周起始日配置

这个 PR 是什么类型? (至少选择一个)

这个 PR 涉及以下平台:

  • NutUI 2.0
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@szg2008 szg2008 requested a review from lkjh3214 November 7, 2022 11:55
title="Select Single Date"
:desc="date ? `${date} ${dateWeek}` : 'Please Select Date'"
@click="openSwitch('isVisible')"
:first-day-of-week="2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是写错地方了吧

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc.md 里面的API可以加一下props说明。同时,可以在 tests /calendar.spec.ts 中加一下单元测试

title="选择单个日期"
:desc="date ? `${date} ${dateWeek}` : '请选择'"
@click="openSwitch('isVisible')"
:first-day-of-week="2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也是写错了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试用例与文档都已经调整

@lkjh3214 lkjh3214 self-requested a review November 15, 2022 10:54
@thx125
Copy link
Contributor Author

thx125 commented Nov 16, 2022

单元测试已经添加,并修复了文档

@szg2008 szg2008 merged commit 234d343 into jd-opensource:next Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants