Gpe cr improvements #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for each one, push a branch to <remote>. | ||
| The branch is named following the <branch-prefix>-<sha1> | ||
| pattern and points to <sha1>. | ||
| By default <branch-prefix> is 'gpe' and <remote> is |
There was a problem hiding this comment.
i had the prefix as 'gpe-' so that people could change it to whatever/ if they prefer some other delimiter. (some tools are dumb and can get confused if branch names have /, hence i defaulted to -, though / is nicer)
this probably isn't a big deal.
There was a problem hiding this comment.
Ok, I changed it to 'gpe-' in the first commit, rebased and force pushed.
|
This LGTM! thanks @chriscool |
- Add a DESCRIPTION section with some explanations. - Show that <remote> and <branch-prefix> are optional. - Tell what are the default values for them. License: MIT Signed-off-by: Christian Couder <[email protected]>
And use it properly in case of unrecognized option. License: MIT Signed-off-by: Christian Couder <[email protected]>
License: MIT Signed-off-by: Christian Couder <[email protected]>
License: MIT Signed-off-by: Christian Couder <[email protected]>
License: MIT Signed-off-by: Christian Couder <[email protected]>
License: MIT Signed-off-by: Christian Couder <[email protected]>
License: MIT Signed-off-by: Christian Couder <[email protected]>
This makes it possible to check that "git branch -r" worked. License: MIT Signed-off-by: Christian Couder <[email protected]>
chriscool
force-pushed
the
gpe-cr-improvements
branch
from
3dc07e4 to
f0ca0e7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2 (Code Review?)