-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not build with CMake 4.0. #1352
Comments
Changing the Lines 1 to 3 in 28f93bd
Maybe |
Just creating some noise here; CMake 4.0 is currently being deployed all over the place (e.g. packaged alongside other tools), and this deprecation is creating build errors for projects which directly or transitively depend on yaml-cpp. A version bump to at least 3.5 should occur ASAP. CC @jbeder. |
@junhaoliao Are you building the release version and quoting the latest master source code? CMake 4.0 builds the latest master without error for me. The error description even specifically says what's on master is a recommended solution.
|
The minimum version as referenced in #1352 (comment) is the current state of master branch. This PR is needed => #1351 |
My project, which also using this library as a submodule, is hitting this problem while its build test with github actions:
So hoping the modification on this line should be done very soon. |
Hi do we have a target date for the fix? |
@Blzut3 |
We have the same issue. Azure updated their Ubuntu agent so it uses CMake 3.31 now, which complains about the A patch release 0.8.1 with followin PR would fix the issue: #1351 |
@mskripnik Isn't the error pointing to the bundled gtest directory? I believe Conan sets BUILD_TESTING to ON by default. With testing off (or presumably using a system copy of gtest) yaml-cpp master should configure and build with CMake 4.0 no warnings or errors. |
The project now does not build with the latest version
4.0.0
of CMakeThe text was updated successfully, but these errors were encountered: