Skip to content

Convert the README from rst to md #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

shatakshiiii
Copy link
Contributor

This PR converts the documentation from README.rst to README.md
Related: #1856

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@ssbarnea ssbarnea marked this pull request as draft May 5, 2023 10:34
@ssbarnea ssbarnea added the bug Something is not working label May 5, 2023
@webknjaz webknjaz added docs Documentation related refactor Refactoring code maintenance Related to maintenance processes enhancement Improvements to functionality packaging Packaging related stuff and removed bug Something is not working labels May 7, 2023
@@ -0,0 +1,564 @@
[![jazzband](https://jazzband.co/static/img/badge.svg)](https://jazzband.co/)
Copy link
Member

@webknjaz webknjaz May 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz make all the link and image URLs detached so that it's easier to follow the syntax when these things are smashed together. Decoupling them also makes it possible to reuse some of the references and maintain them in a detached manner.

Note that the original document already follows this practice. The new one must keep it in place.

Similar to `pip`, `pip-tools` must be installed in each of your project's
[virtual environments](https://packaging.python.org/tutorials/installing-packages/#creating-virtual-environments):

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For code snippets with shell prompts and command output, always use the console highligher:

Suggested change
```
```console

A set of command line tools to help you keep your `pip`-based packages fresh,
even when you've pinned them. You do pin them, right? (In building your Python application and its dependencies for production, you want to make sure that your builds are predictable and deterministic.)

[![pip-tools overview for phase II](https://github.com/jazzband/pip-tools/raw/main/img/pip-tools-overview.svg)](https://github.com/jazzband/pip-tools/raw/main/img/pip-tools-overview.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: separate the URLs.

Suppose you have a 'foobar' Python application that is packaged using `Setuptools`,
and you want to pin it for production. You can declare the project metadata as:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep all the lexer specifications from the original document.

Suggested change
```
```toml


Now, run `pip-compile requirements.in`:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with other snippets.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting this off! Here's a few things that this PR needs to address before it's ready:

  • make the external links detached from the places where they are used (I've noted a few places via inline comments but there's more)
  • preserve the original code block lexers — it's important for syntax highlighting; there's a few inline notes but you need to inspect all of them
  • fix the Sphinx inclusion; in the current state, it won't find the removed file @ https://github.com/jazzband/pip-tools/blob/main/docs/index.rst — you'll probably need to convert that document to MyST markdown too.

As one of the acceptance criteria, please make sure that the RTD build does not fail, then ensure that https://pip-tools--1862.org.readthedocs.build/en/1862/ renders the same as https://pip-tools.readthedocs.io/en/latest/.

@chrysle
Copy link
Contributor

chrysle commented May 8, 2023

As one of the acceptance criteria, please make sure that the RTD build does not fail

@webknjaz This is a generic problem with RTD since urllib3 version 2 was released a few days ago.

It should be fixed like in pypa/twine#991

@webknjaz
Copy link
Member

webknjaz commented May 8, 2023

This is a generic problem with RTD since urllib3 version 2 was released a few days ago.

No, the one I was referring to is caused by the PR.

@chrysle
Copy link
Contributor

chrysle commented May 9, 2023

No, the one I was referring to is caused by the PR.

Do you mean the workflow "QA / build-docs" or "docs/readthedocs.org:pip-tools"? The ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+... is caused by the problem I mentioned.

@webknjaz
Copy link
Member

webknjaz commented May 9, 2023

"docs/readthedocs.org:pip-tools

I mean RTD. But the CI job would also fail. I haven't looked into the logs. This is solely based on the observation that .. include:: README.rst stopped working because this file is deleted and the document with the inclusion wasn't updated to point to the new one.

@webknjaz
Copy link
Member

webknjaz commented May 9, 2023

@chrysle but please feel free to send a PR updating the RTD config. This is a welcome change, just not directly related to what's happening in this one.

@webknjaz
Copy link
Member

webknjaz commented May 9, 2023

feel free to send a PR updating the RTD config

I've made one myself: #1864

@chrysle chrysle mentioned this pull request May 10, 2023
chrysle added a commit to chrysle/pip-tools that referenced this pull request May 12, 2023
@chrysle chrysle mentioned this pull request May 12, 2023
4 tasks
chrysle added a commit to chrysle/pip-tools that referenced this pull request May 13, 2023
chrysle added a commit to chrysle/pip-tools that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related enhancement Improvements to functionality maintenance Related to maintenance processes packaging Packaging related stuff refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants