[Mosaic GPU] Implement meet and join for replicated layouts.
#29952
+482
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
We no longer assume that two layouts within a `{Least,Most}ReplicatedExpression`
are always compatible, and now make sure to reduce all the layout expressions
within the replicated expression before deciding whether a least/most
replicated expression even exists.
This is the correct behaviour to have for equations. The logic implemented
previously is appropriate for `Hint`s, and will be added to the layout
inference in an upcoming change.
PiperOrigin-RevId: 778497953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mosaic GPU] Implement
meetandjoinfor replicated layouts.We no longer assume that two layouts within a
{Least,Most}ReplicatedExpressionare always compatible, and now make sure to reduce all the layout expressions
within the replicated expression before deciding whether a least/most
replicated expression even exists.
This is the correct behaviour to have for equations. The logic implemented
previously is appropriate for
Hints, and will be added to the layoutinference in an upcoming change.