-
Notifications
You must be signed in to change notification settings - Fork 25
Adding tutorial for data loaders in multi device setups #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/conf.py
Outdated
@@ -56,6 +56,8 @@ | |||
'JAX_basic_text_classification.md', | |||
'JAX_examples_image_segmentation.md', | |||
'JAX_Vision_transformer.md', | |||
'data_loaders_on_cpu_with_jax.md', | |||
'data_loaders_on_gpu_with_jax.md', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add the data_loaders_for_multi_device_setups_with_jax.md
filename to the contents here.
|
||
+++ {"id": "PUFGZggH49zp"} | ||
|
||
## Introduction to Data Loaders for Multi-Device Training with JAX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First heading should be H1
## Introduction to Data Loaders for Multi-Device Training with JAX | ||
|
||
+++ {"id": "3ia4PKEV5Dr8"} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with the GPU tutorial, it would be useful here to give a quick summary of what differs between this tutorial and the others in the series.
Headings adjusted and new overview paragraph added into the introduction. |
@selamw1 there seem to be a couple of merge conflicts here would you be able to fix them, please? |
13088a3
to
8eb0884
Compare
File conflict resolved. |
Similar comment here as in #109 (comment) – this will be the third in a sequence of very similar tutorials on data loading – it's hard to know from reading this what the expected takeaway is compared to the previous two. We should think of this not as a standalone notebook, but as a third chapter in a sequence of documents that builds on the previous ones – orienting the reader around that would make this a much more effective doc I think. |
3c6b421
to
68eab1f
Compare
#109 (comment) has been adjusted by new PR. Accordingly, this notebooks have been adjusted to highlight the key differences between each other, and their respective references have been added to make them standalone tutorials. |
Thanks - we'll have to rebase this PR to reflect the fact that |
68eab1f
to
7b28cb6
Compare
|
4430d13
to
e88d55c
Compare
Due to file conflicts and rebasing several commits has been done. |
Introduction to Data Loaders for Multi-Device Training with JAX.