Skip to content

_.memoize hasher result cannot be a symbol. #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdalton opened this issue Apr 14, 2016 · 3 comments
Closed

_.memoize hasher result cannot be a symbol. #2497

jdalton opened this issue Apr 14, 2016 · 3 comments
Labels
duplicate

Comments

@jdalton
Copy link
Contributor

jdalton commented Apr 14, 2016

Because the _.memoize hasher is resolved with '' + it will throw an error if the hasher result is a Symbol. A similar issue exists in createEscaper.
xcodebuild added a commit to xcodebuild/underscore that referenced this issue May 4, 2016
@xcodebuild
fix jashkenas#2497, make _.memoize work with symbol
d35fb03
@xcodebuild
Copy link
Contributor

But createEscaper just won't work with symbol, what should we do here?

@blacklovebear
Copy link

Does "memoize" spell wrong??? I'm confused

@jgonggrijp
Copy link
Collaborator

Duplicate of #1862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdalton @jgonggrijp @blacklovebear @xcodebuild