Fixes #345, fixes #346: Exception code tweaks #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalroz
force-pushed
the
fix-345
branch
2 times, most recently
from
8935d36 to
7c6d5bf
Compare
|
This is good, but I think it needs rebasing after the namespace fixes. |
|
Yes, I'll take care of that soon. |
…exceptions in a sub-namespace and renamed them accordingly. * Also fixed some "loose ends" regarding namespace indentation which were missing in PR jarro2783#350.
|
@jarro2783 : Done, and also had to make a few more changes regarding namespace indentation which slipped by me in PR #350. |
|
@jarro2783 : After this, let's go for #349 . |
|
So, somehow after the merge, the exceptions namespace itself is indented. Will submit another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts exceptions in their own sub-namespace and renames some of them accordingly.
Note that I think there might be an over-abundance of exception classes in the library, but so be it...
This change is