Skip to content

Fix mysql2 invalid configuration (#788) #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Conversation

kossidts
Copy link
Contributor

@kossidts kossidts commented Apr 21, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Exclude configuration options specific to keyv from the mysql2 connection options. This change fixes mysql2 invalid configuration warnings. MySQL2 will likely throw an error in future version.

The change require neither additional tests nor documentation. The tests run with 100% code coverage.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e7bcc2) 100.00% compared to head (a6bc47f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #789   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2419      2419           
  Branches       143       143           
=========================================
  Hits          2419      2419           
Impacted Files Coverage Δ
packages/mysql/src/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants