Skip to content

fix(ocm): replace usage of pf-icons to mui icons #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

debsmita1
Copy link
Member

@debsmita1 debsmita1 commented Sep 30, 2024

Resolves:
https://issues.redhat.com/browse/RHIDP-3796

Screenshot:

Screenshot 2024-10-01 at 4 09 45 PM

Test setup

OCM plugin setup

apiVersion: operator.open-cluster-management.io/v1
kind: MultiClusterHub
metadata:
  name: multiclusterhub
  namespace: deb-test
spec:
  imagePullSecret: my-image-secret
  tolerations:
  - key: node-role.kubernetes.io/infra
    effect: NoSchedule
    operator: Exists
  availabilityConfig: "Basic"
  nodeSelector:
    node-role.kubernetes.io/infra: ""

@debsmita1 debsmita1 requested review from a team as code owners September 30, 2024 17:19
@debsmita1 debsmita1 changed the title [ocm] : replace usage of pf-icons to mui icons fix(ocm) : replace usage of pf-icons to mui icons Oct 1, 2024
@debsmita1 debsmita1 force-pushed the ocm-pf-icons-update branch from f6231f3 to 0abe31f Compare October 1, 2024 06:12
@debsmita1 debsmita1 changed the title fix(ocm) : replace usage of pf-icons to mui icons fix(ocm): replace usage of pf-icons to mui icons Oct 1, 2024
@debsmita1 debsmita1 force-pushed the ocm-pf-icons-update branch from 0abe31f to cb5b2d1 Compare October 1, 2024 06:37
@debsmita1 debsmita1 requested review from christoph-jerolimov and removed request for dzemanov and Fortune-Ndlovu October 1, 2024 06:38
@debsmita1 debsmita1 force-pushed the ocm-pf-icons-update branch from cb5b2d1 to f815f4e Compare October 1, 2024 06:42
@debsmita1 debsmita1 force-pushed the ocm-pf-icons-update branch from f815f4e to 819a938 Compare October 1, 2024 10:43
@invincibleJai
Copy link
Member

/cc @jerolimov
/cc @invincibleJai

@openshift-ci openshift-ci bot requested a review from invincibleJai October 3, 2024 12:38
@debsmita1 debsmita1 force-pushed the ocm-pf-icons-update branch 2 times, most recently from 8beb15e to 6cfd4ed Compare October 8, 2024 13:16
@invincibleJai
Copy link
Member

/cc @its-mitesh-kumar

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 664a0c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@janus-idp/shared-react Minor
@janus-idp/backstage-plugin-ocm Minor
@janus-idp/backstage-plugin-bulk-import Patch
@janus-idp/backstage-plugin-jfrog-artifactory Patch
@janus-idp/backstage-plugin-openshift-image-registry Patch
@janus-idp/backstage-plugin-quay Patch
@janus-idp/backstage-plugin-rbac Patch
@janus-idp/backstage-plugin-tekton Patch
@janus-idp/backstage-plugin-topology Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@debsmita1 debsmita1 force-pushed the ocm-pf-icons-update branch 2 times, most recently from 8a2187b to 70672f6 Compare October 18, 2024 07:59
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this before:

@debsmita1 debsmita1 force-pushed the ocm-pf-icons-update branch from def6019 to 664a0c8 Compare October 18, 2024 16:59
Copy link

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. I've tested this with tekton and topology plugin. The gap between icon and status label was a bit bigger, but it still looks good.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fef0f60 into janus-idp:main Oct 20, 2024
9 checks passed
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants