-
Notifications
You must be signed in to change notification settings - Fork 155
fix(ocm): replace usage of pf-icons to mui icons #2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ocm): replace usage of pf-icons to mui icons #2275
Conversation
f6231f3
to
0abe31f
Compare
0abe31f
to
cb5b2d1
Compare
cb5b2d1
to
f815f4e
Compare
f815f4e
to
819a938
Compare
/cc @jerolimov |
8beb15e
to
6cfd4ed
Compare
6cfd4ed
to
8bd2602
Compare
🦋 Changeset detectedLatest commit: 664a0c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8a2187b
to
70672f6
Compare
70672f6
to
995bdd0
Compare
995bdd0
to
3f360dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this before:
3f360dc
to
def6019
Compare
def6019
to
664a0c8
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. I've tested this with tekton and topology plugin. The gap between icon and status label was a bit bigger, but it still looks good.
/lgtm
Resolves:
https://issues.redhat.com/browse/RHIDP-3796
Screenshot:
Test setup
OCM plugin setup
Create a namespace “deb-test”
Install the Advanced Cluster Management for Kubernetes operator
Create MultiClusterHub Custom resource under deb-test namespace
oc create secret generic my-image-secret -n deb-test --from-file=.dockerconfigjson=./pull-secret.txt --type=kubernetes.io/dockerconfigjson