Skip to content

feat(topology): show vm node details in the sidepanel #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat(topology): show vm node details in the sidepanel #2084

merged 5 commits into from
Aug 28, 2024

Conversation

its-mitesh-kumar
Copy link
Contributor

@its-mitesh-kumar its-mitesh-kumar commented Aug 25, 2024 •
edited by debsmita1
Loading

@openshift-ci openshift-ci bot requested review from dzemanov and JessicaJHee August 25, 2024 22:19
@its-mitesh-kumar its-mitesh-kumar marked this pull request as draft August 25, 2024 22:20
@debsmita1 debsmita1 changed the title feat(topology-vm-sidebar) : show details in sidebar feat(topology) : show vm node details in the sidepanel Aug 26, 2024
@debsmita1 debsmita1 changed the title feat(topology) : show vm node details in the sidepanel feat(topology): show vm node details in the sidepanel Aug 26, 2024
christoph-jerolimov
christoph-jerolimov requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes also if this is in draft status:

@its-mitesh-kumar its-mitesh-kumar marked this pull request as ready for review August 26, 2024 15:17
@openshift-ci openshift-ci bot requested a review from 04kash August 26, 2024 15:17
debsmita1
debsmita1 requested changes Aug 27, 2024
View reviewed changes
@debsmita1
Copy link
Member

The Service created by the VM doesn't show up on the sidepanel

you would need to add

case 'VirtualMachine':
        return resource?.spec?.template;

in the getPodTemplate util

@its-mitesh-kumar its-mitesh-kumar force-pushed the feat/topology-vm-sidepanel branch from df2aef5 to 557c756 Compare August 27, 2024 09:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@debsmita1 debsmita1 self-requested a review August 27, 2024 16:59
debsmita1
debsmita1 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified this locally
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 27, 2024
@christoph-jerolimov
Copy link
Member

/unassign

@openshift-merge-bot openshift-merge-bot bot merged commit e87a023 into main Aug 28, 2024
11 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the feat/topology-vm-sidepanel branch August 28, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@invincibleJai invincibleJai invincibleJai approved these changes

@debsmita1 debsmita1 debsmita1 approved these changes

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta divyanshiGupta is a code owner

@dzemanov dzemanov Awaiting requested review from dzemanov

@JessicaJHee JessicaJHee Awaiting requested review from JessicaJHee

@04kash 04kash Awaiting requested review from 04kash

Assignees

@invincibleJai invincibleJai

@debsmita1 debsmita1

@its-mitesh-kumar its-mitesh-kumar

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@its-mitesh-kumar @debsmita1 @christoph-jerolimov @invincibleJai