Skip to content

chore: add deprecate note to the argocd plugin #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 19, 2024
Merged

chore: add deprecate note to the argocd plugin #2062

merged 5 commits into from
Aug 19, 2024

Conversation

Fortune-Ndlovu
Copy link
Member

@Fortune-Ndlovu Fortune-Ndlovu commented Aug 19, 2024

Jira Issue: https://issues.redhat.com/browse/RHIDP-3548

Both the argocd and argocd-common plugins have been migrated to the backstage/community-plugins repository in support of our sunsetting efforts.

This Pull Request is adding a note within the backstage-plugins repository about both the argocd and argocd-common plugins being deprecated. It is also setting the package.json files to private "private": true, to prevent accidental publishing of deprecated plugin.

@Fortune-Ndlovu Fortune-Ndlovu requested review from a team as code owners August 19, 2024 11:42
@openshift-ci openshift-ci bot requested review from 04kash and dzemanov August 19, 2024 11:42
@Fortune-Ndlovu Fortune-Ndlovu changed the title Add deprecate note chore: Add deprecate note Aug 19, 2024
…e to prevent accidental publishing of deprecated plugin
@Fortune-Ndlovu Fortune-Ndlovu requested a review from a team as a code owner August 19, 2024 11:58
…event accidental publishing of deprecated plugin
@Fortune-Ndlovu Fortune-Ndlovu changed the title chore: Add deprecate note chore: add deprecate note Aug 19, 2024
@Fortune-Ndlovu Fortune-Ndlovu changed the title chore: add deprecate note chore: add deprecate note to the argocd plugin Aug 19, 2024
Copy link

@nickboldt
Copy link
Member

+1, seems reasonable to deprecate now (and eventually these will be readonly when we archive the repo)

@openshift-ci openshift-ci bot added the lgtm label Aug 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ae6f43b into janus-idp:main Aug 19, 2024
12 checks passed
debsmita1 pushed a commit to debsmita1/backstage-plugins that referenced this pull request Aug 20, 2024
* Update README.md - adding deprecated note to the plugin

* Update README.md - adding deprecated note to the plugin

* Update package.json - chore: Set argocd-common package.json to private to prevent accidental publishing of deprecated plugin

* Update package.json - chore: Set argocd package.json to private to prevent accidental publishing of deprecated plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants