Skip to content

feat(topology): add virtual machine visualization in topology #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

its-mitesh-kumar
Copy link
Contributor

@its-mitesh-kumar its-mitesh-kumar commented Aug 7, 2024

@debsmita1 debsmita1 changed the title Feat/topology vm Feat(topology): add virtual machine visualization in topology Aug 8, 2024
Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check on OpenShift if the image is supposed to occupy the entire node's space?

Screenshot 2024-08-09 at 8 04 10 PM

@its-mitesh-kumar
Copy link
Contributor Author

Could you check on OpenShift if the image is supposed to occupy the entire node's space?

Screenshot 2024-08-09 at 8 04 10 PM

Openshift Node look like this
Screenshot 2024-08-13 at 2 37 06 PM (2)
zoomed Openshift Node look like this
Screenshot 2024-08-13 at 2 39 31 PM
Backstage Plugin
Screenshot 2024-08-13 at 2 40 35 PM
Its look same to me @debsmita1

@its-mitesh-kumar its-mitesh-kumar marked this pull request as ready for review August 13, 2024 13:49
@openshift-ci openshift-ci bot requested review from dzemanov and JessicaJHee August 13, 2024 13:49
@debsmita1 debsmita1 changed the title Feat(topology): add virtual machine visualization in topology feat(topology): add virtual machine visualization in topology Aug 14, 2024
@debsmita1
Copy link
Member

tested it locally, the UI looks good

Copy link

@debsmita1
Copy link
Member

tested this locally
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 19, 2024
@debsmita1
Copy link
Member

/approve

Copy link
Member

@invincibleJai invincibleJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-merge-bot openshift-merge-bot bot merged commit c2b95fa into main Aug 20, 2024
11 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the feat/topology-vm branch August 20, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants