-
Notifications
You must be signed in to change notification settings - Fork 155
feat: add method for janus-cli package metadata
; generate updates to package.json for all plugins listed in plugins/plugin-metadata.json
#1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/lgtm |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreydaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
403489a
to
58a5137
Compare
janus-cli package metadata
e7fa4f8
to
601a855
Compare
601a855
to
4029b16
Compare
Signed-off-by: Nick Boldt <[email protected]> experimenting with a new packages/cli/src/commands/metadata/index.ts command Signed-off-by: Nick Boldt <[email protected]> lint changes and fix to readme Signed-off-by: Nick Boldt <[email protected]> implement metadata generation from CODEOWNERS and some hardcoded values Signed-off-by: Nick Boldt <[email protected]> implement metadata generation from CODEOWNERS and some hardcoded values Signed-off-by: Nick Boldt <[email protected]> quieter output; updated sample; regen yarn lock Signed-off-by: Nick Boldt <[email protected]> quieter output; updated sample; regen yarn lock Signed-off-by: Nick Boldt <[email protected]> move hardcoded defaults into cmdline options; support running in root folder against a specific plugins/* folder Signed-off-by: Nick Boldt <[email protected]> change description and instuctions Signed-off-by: Nick Boldt <[email protected]> include script for batch updating all the RH supported plugins included in showcase; for now, don't update metadata in the non-included plugins Signed-off-by: Nick Boldt <[email protected]> switch from execSync to run git to using gitconfiglocal (to just parse the .git/config file) (sonarlint) Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]> experimenting with a new packages/cli/src/commands/metadata/index.ts command Signed-off-by: Nick Boldt <[email protected]> lint changes and fix to readme Signed-off-by: Nick Boldt <[email protected]> implement metadata generation from CODEOWNERS and some hardcoded values Signed-off-by: Nick Boldt <[email protected]> implement metadata generation from CODEOWNERS and some hardcoded values Signed-off-by: Nick Boldt <[email protected]> quieter output; updated sample; regen yarn lock Signed-off-by: Nick Boldt <[email protected]> quieter output; updated sample; regen yarn lock Signed-off-by: Nick Boldt <[email protected]> move hardcoded defaults into cmdline options; support running in root folder against a specific plugins/* folder Signed-off-by: Nick Boldt <[email protected]> change description and instuctions Signed-off-by: Nick Boldt <[email protected]> include script for batch updating all the RH supported plugins included in showcase; for now, don't update metadata in the non-included plugins Signed-off-by: Nick Boldt <[email protected]> switch from execSync to run git to using gitconfiglocal (to just parse the .git/config file) (sonarlint) Signed-off-by: Nick Boldt <[email protected]> switch yarn lock to use registry.yarnpkg.com Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]> add TODOs to the plugins/plugin-metadata.sh and plugins/plugin-metadata.json files Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
* feat: RHIDP-1502 add method for janus-cli package metadata Signed-off-by: Nick Boldt <[email protected]> experimenting with a new packages/cli/src/commands/metadata/index.ts command Signed-off-by: Nick Boldt <[email protected]> lint changes and fix to readme Signed-off-by: Nick Boldt <[email protected]> implement metadata generation from CODEOWNERS and some hardcoded values Signed-off-by: Nick Boldt <[email protected]> implement metadata generation from CODEOWNERS and some hardcoded values Signed-off-by: Nick Boldt <[email protected]> quieter output; updated sample; regen yarn lock Signed-off-by: Nick Boldt <[email protected]> quieter output; updated sample; regen yarn lock Signed-off-by: Nick Boldt <[email protected]> move hardcoded defaults into cmdline options; support running in root folder against a specific plugins/* folder Signed-off-by: Nick Boldt <[email protected]> change description and instuctions Signed-off-by: Nick Boldt <[email protected]> include script for batch updating all the RH supported plugins included in showcase; for now, don't update metadata in the non-included plugins Signed-off-by: Nick Boldt <[email protected]> switch from execSync to run git to using gitconfiglocal (to just parse the .git/config file) (sonarlint) Signed-off-by: Nick Boldt <[email protected]> * include individual plugin/*/package.json updates Signed-off-by: Nick Boldt <[email protected]> * feat: RHIDP-1502 add method for janus-cli package metadata Signed-off-by: Nick Boldt <[email protected]> experimenting with a new packages/cli/src/commands/metadata/index.ts command Signed-off-by: Nick Boldt <[email protected]> lint changes and fix to readme Signed-off-by: Nick Boldt <[email protected]> implement metadata generation from CODEOWNERS and some hardcoded values Signed-off-by: Nick Boldt <[email protected]> implement metadata generation from CODEOWNERS and some hardcoded values Signed-off-by: Nick Boldt <[email protected]> quieter output; updated sample; regen yarn lock Signed-off-by: Nick Boldt <[email protected]> quieter output; updated sample; regen yarn lock Signed-off-by: Nick Boldt <[email protected]> move hardcoded defaults into cmdline options; support running in root folder against a specific plugins/* folder Signed-off-by: Nick Boldt <[email protected]> change description and instuctions Signed-off-by: Nick Boldt <[email protected]> include script for batch updating all the RH supported plugins included in showcase; for now, don't update metadata in the non-included plugins Signed-off-by: Nick Boldt <[email protected]> switch from execSync to run git to using gitconfiglocal (to just parse the .git/config file) (sonarlint) Signed-off-by: Nick Boldt <[email protected]> switch yarn lock to use registry.yarnpkg.com Signed-off-by: Nick Boldt <[email protected]> * add missing type declaration for gitconfiglocal Signed-off-by: Nick Boldt <[email protected]> * add missing copyright / fix date Signed-off-by: Nick Boldt <[email protected]> add TODOs to the plugins/plugin-metadata.sh and plugins/plugin-metadata.json files Signed-off-by: Nick Boldt <[email protected]> * process all 42 plugins in the repo Signed-off-by: Nick Boldt <[email protected]> * process all 42 plugins in the repo Signed-off-by: Nick Boldt <[email protected]> * refactor command.ts Signed-off-by: Paul Schultz <[email protected]> * fix sh Signed-off-by: Paul Schultz <[email protected]> * add lines Signed-off-by: Paul Schultz <[email protected]> * Update packages/cli/src/commands/metadata/command.ts --------- Signed-off-by: Nick Boldt <[email protected]> Signed-off-by: Paul Schultz <[email protected]> Co-authored-by: Nick Boldt <[email protected]>
…nt stuff Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
239afff
to
0801f75
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
"@janus-idp/maintainers-plugins", | ||
"@janus-idp/devex-uxe" | ||
], | ||
"author": "The Backstage Community" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riginoommen @deshmukhmayur what should be there in author field?
|
replaced by #1753 |
What does this PR do?
feat: add method for
janus-cli package metadata
RHIDP-1502 ;generate updates to package.json for all plugins listed in plugins/plugin-metadata.json
Signed-off-by: Nick Boldt [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
Or use the script wrapper to run against a list of plugins:
Followup tasks would be to contribute this script / app to upstream community-plugins repo, so we can run it against existing/future plugins and incorporate it into lifecycle automation.
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.