chore(deps): fail the build if workspace dirty after a yarn install (yarn.lock changed) (RHIDP-1203) #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n install (yarn.lock changed) Signed-off-by: Nick Boldt <[email protected]>
nickboldt
changed the title
Signed-off-by: Nick Boldt <[email protected]>
gashcrumb
approved these changes
Apr 9, 2024
davidfestal
changed the title
davidfestal
reviewed
Apr 9, 2024
davidfestal
approved these changes
Apr 9, 2024
davidfestal
requested changes
Apr 10, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gashcrumb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nickboldt
commented
Apr 10, 2024
nickboldt
commented
Apr 10, 2024
|
|
Thanks Nick 👍 LGTM |
nickboldt
deleted the
fail-build-test-pr-if-workspace-dirty-after-yarn-install
branch
|
manually cherrypicked as #1494 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore(deps): RHIDP-1203 fail the build if workspace dirty after a yarn install (yarn.lock changed)
Signed-off-by: Nick Boldt [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/RHIDP-1203
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.