Skip to content

fix(orchestrator): fixes v2/instances endpoint #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jkilzi
Copy link
Member

@jkilzi jkilzi commented Mar 26, 2024

The start and end fields of the ProcessInstanceare annotated as strings instead of Date now. The format of the string is provided as a hint for the developer as a comment (date-time) due to limitations in the OpenAPI code generator.

@jkilzi jkilzi requested a review from a team as a code owner March 26, 2024 23:09
@openshift-ci openshift-ci bot requested review from batzionb and caponetto March 26, 2024 23:09
Copy link

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jkilzi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkilzi
Copy link
Member Author

jkilzi commented Mar 26, 2024

The "Build all packages" task is failing due to a type-check error in our code base, unrelated to the changes I've made.
@caponetto PTAL 🙏

The "Test" job failed due to a code styling issue in a readme file located outside of our code base 🤷

@batzionb
Copy link
Contributor

The "Build all packages" task is failing due to a type-check error in our code base, unrelated to the changes I've made. @caponetto PTAL 🙏

The "Test" job failed due to a code styling issue in a readme file located outside of our code base 🤷

@jkilzi this PR #1409 resolved the issue
the tests should be rerun

@batzionb
Copy link
Contributor

/test

Copy link

openshift-ci bot commented Mar 27, 2024

@batzionb: No presubmit jobs available for janus-idp/backstage-plugins@main

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@batzionb
Copy link
Contributor

/retest

@jkilzi
Copy link
Member Author

jkilzi commented Mar 27, 2024

/rebase

The `start` and `end` fields are annotated as `strings` instead of `Date`. The format of the string is provided as a hint for the developer as a comment (date-time)  due to limitations in the OpenAPI code generator.
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jkilzi
Copy link
Member Author

jkilzi commented Mar 27, 2024

I'll reopen this PR (here) from a feature branch instead of from my main branch

@jkilzi jkilzi closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants