fix(orchestrator): stop fetching workflow URI #1297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gciavarrini could you please help me review this PR? Especially the API part. |
gciavarrini
reviewed
Feb 29, 2024
caponetto
force-pushed
the
FLPATH-1044
branch
from
58668ce to
56599c8
Compare
caponetto
force-pushed
the
FLPATH-1044
branch
from
56599c8 to
aadfffa
Compare
|
|
@jkilzi PTAL |
|
LGTM |
batzionb
approved these changes
Mar 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: batzionb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/FLPATH-1044
We were fetching each workflow URI directly from the workflow service when loading the workflow table.
If one of the services is not responsive, the loading operation fails. Not to mention that it adds one extra request for each item in the table.
I've noticed that we were using the workflow URI only for authoring purposes so I'm removing this field in favor of the
formatfield (json|yaml), which can be extracted from the workflow source, i.e., does not depend on fetching the workflow service directly.I've also taken the opportunity to improve our API by simplifying some of the operations and removing others that are not being used anymore. There's still room for improvement and this PR is a proposal for a first step.