Skip to content

docs: Add dynamic plugin setup/installation instruction for the janus-idp plugins #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

jesuino
Copy link
Contributor

@jesuino jesuino commented Feb 9, 2024

Added brief information about dynamic plugins installation to the README.md, but linking the main Dynamic Plugins docs to avoid information duplication. The README.md instruction is just to let users know about this possibility and direct them to a more complete document.

@jesuino jesuino requested a review from a team as a code owner February 9, 2024 19:32
@@ -12,6 +12,50 @@ A subset of available Janus IDP plugins is available at our [community site](htt

You can also see the [Plugin Marketplace](https://backstage.io/plugins) for other open-source plugins you can add to your Backstage instance.

## Dynamic Plugins Installation

It is possible to install plugins without code changes in a backstage that supports [Dynamic Plugins](https://github.com/janus-idp/backstage-showcase/blob/main/showcase-docs/dynamic-plugins.md) (e.g. [Janus IDP](https://janus-idp.io/) and [Red Hat Developer Hub](https://developers.redhat.com/rhdh)). Follow the steps below to install a dynamic plugin:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any prerequisite for enabling the dynamic plugins?
I mean, can a user just use this procedure in a random version of Janus-IDP/Backstage, or should they first make sure a specific version is available, or anything perhaps something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jkilzi I confirmed that no additional configuration is required to enable dynamic plugins. Regarding what version to use, I know that dynamic plugins are available in RHDH starting on 1.0, but for Janus IDP I recommend users to check if the endpoint /api/dynamic-plugins-info/loaded-plugins, if it is available, then you can use dynamic plugins.

Please bear in mind that upstream backstage does not support dynamic plugins ATM.

README.md Outdated
tar -xzvf {path to the NPM package tgz file} -C {plugin name} --strip-components=1
```

- Configure your plugin in `app-config.yaml`. For example, the configuration below will make a new menu item to access the plugin on route `my-plugin`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using app-config.local.yaml instead here, it's generally better when working locally to try and stick with this file rather than modifying one of the tracked configuration files in the repo like app-config.yaml

README.md Outdated

It is possible to install plugins without code changes in a backstage that supports [Dynamic Plugins](https://github.com/janus-idp/backstage-showcase/blob/main/showcase-docs/dynamic-plugins.md) (e.g. [Janus IDP](https://janus-idp.io/) and [Red Hat Developer Hub](https://developers.redhat.com/rhdh)). Follow the steps below to install a dynamic plugin:

- Map the dynamic plugins root directory in `app-config.yaml`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app-config.local.yaml, sorry missed this one before commenting on the other one :-)

Copy link
Member

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just one suggestion and I think it's good.

@jesuino
Copy link
Contributor Author

jesuino commented Feb 21, 2024

@gashcrumb done, thanks!

Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openshift-ci openshift-ci bot added the lgtm label Mar 4, 2024
@invincibleJai
Copy link
Member

/approve

Copy link

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8964469 into janus-idp:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants