Skip to content

chore: sync yarn.lock #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

invincibleJai
Copy link
Member

Running yarn install on main results in the following diff

@invincibleJai invincibleJai requested a review from a team as a code owner January 30, 2024 13:39
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@caponetto
Copy link
Contributor

Thanks @invincibleJai!
I wonder if we could have a check after this step
Something like this

    - name: "Check yarn.lock"
      shell: bash
      run: |
        echo "Check yarn.lock"
        git diff yarn.lock;
        [ "0" == "$(git diff yarn.lock | wc -l | tr -d ' ')" ]

The build would break if there is a diff in the lock.

Copy link
Contributor

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@invincibleJai
Copy link
Member Author

Thanks @invincibleJai! I wonder if we could have a check after this step Something like this

    - name: "Check yarn.lock"
      shell: bash
      run: |
        echo "Check yarn.lock"
        git diff yarn.lock;
        [ "0" == "$(git diff yarn.lock | wc -l | tr -d ' ')" ]

The build would break if there is a diff in the lock.

yeah we should be adding this

@kadel ^^ and if you can approve the PR

@debsmita1
Copy link
Member

/approve

Copy link

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, gashcrumb, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gashcrumb
Copy link
Member

gashcrumb commented Feb 5, 2024

Thanks @invincibleJai! I wonder if we could have a check after this step Something like this

    - name: "Check yarn.lock"
      shell: bash
      run: |
        echo "Check yarn.lock"
        git diff yarn.lock;
        [ "0" == "$(git diff yarn.lock | wc -l | tr -d ' ')" ]

The build would break if there is a diff in the lock.

yeah we should be adding this

@kadel ^^ and if you can approve the PR

BTW I created #1169 and also created a similar issue for backstage-showcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants