Fix windows CI #43
Merged
Fix windows CI #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add nbQA commit hooks for pyupgrade, isort, flake8 https://github.com/nbQA-dev/nbQA
…fault value 'composition' to 'element_composition' also refactor count_elements() from pd.Series.apply() to list comprehension for a slight speedup
janosh
added a commit
that referenced
this pull request
Mar 28, 2025
* fix .github/workflows/test.yml had unused strategy matrix.os add nbQA commit hooks for pyupgrade, isort, flake8 https://github.com/nbQA-dev/nbQA * try fix invalid windows file paths in test_plot_structure_2d() reference images * test integer dict keys too in test_count_elements_bad_atomic_nums() * breaking: rename count_elements() kwarg mode to count_mode and its default value 'composition' to 'element_composition' also refactor count_elements() from pd.Series.apply() to list comprehension for a slight speedup * fix check for srs.index of integer dtype in count_elements() on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails due to invalid file paths in reference images created by
test_plot_structure_2d().