Update luminance calculation to use WCAG 2.0 standard coefficients
#278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- breaking: rename `pick_bw_for_contrast()` to `pick_max_contrast_color()` - improve function signatures and docstrings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
===========================================
- Coverage 87.63% 75.17% -12.47%
===========================================
Files 44 44
Lines 4644 4640 -4
Branches 893 891 -2
===========================================
- Hits 4070 3488 -582
- Misses 360 792 +432
- Partials 214 360 +146 ☔ View full report in Codecov by Sentry. |
janosh
force-pushed
the
tweak-color-luminance
branch
from
ea70e40 to
1eff5fd
Compare
janosh
force-pushed
the
tweak-color-luminance
branch
from
1eff5fd to
6a257d1
Compare
janosh
added a commit
that referenced
this pull request
Mar 28, 2025
…278) * update luminance calculation to use WCAG 2.0 standard coefficients - breaking: rename `pick_bw_for_contrast()` to `pick_max_contrast_color()` - improve function signatures and docstrings * skip fetching citation in CI * github-action-markdown-link-check treat HTML status code 403 forbidden as alive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick_bw_for_contrast()topick_max_contrast_color()