phonon_bands enable custom acoustic/optical bands
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…des or callable new admissible types: line_kwargs: dict[Literal["acoustic", "optical"], dict[str, Any]] # function taking (band_data, band_idx) | Callable[[np.ndarray, int], dict[str, Any]]
janosh
added
enhancement
janosh
added a commit
that referenced
this pull request
Mar 28, 2025
* fix NaN handling in ptable_heatmap_splits_plotly * phonon_bands line_kwargs allow separate dicts for acoustic/optical modes or callable new admissible types: line_kwargs: dict[Literal["acoustic", "optical"], dict[str, Any]] # function taking (band_data, band_idx) | Callable[[np.ndarray, int], dict[str, Any]] * test_phonon_bands with acoustic/optical subdict and callable line_kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phonon_bandsline_kwargsallow separate dicts for acoustic/optical modes or function taking (band_data,band_idx)Callable[[np.ndarray, int], dict[str, Any]]Example
red dashed for acoustic, blue dotted for optical