-
Notifications
You must be signed in to change notification settings - Fork 27
Speedup import and add regression check for import time #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b6bee81
pre-commit migrate-config
DanielYang59 5c8032d
avoid import Structure for type check
DanielYang59 212d573
lazily import scipy
DanielYang59 d4e25e7
avoid import Structure in utils
DanielYang59 865a4fa
copy helper func _check_type from monty
DanielYang59 82a31c4
lazy import plotly.figure_factory
DanielYang59 e60c770
lazy import NearNeighbors
DanielYang59 2777c0f
lazy import PhononDos and PhononBands
DanielYang59 13960b4
more lazy import Structure
DanielYang59 07e084c
clean up some duplicate imports
DanielYang59 5c01d25
lazy import sklearn
DanielYang59 5918aeb
lazy import pmg composition
DanielYang59 1161bf0
remove unused import from root __init__
DanielYang59 2b04381
relocate scikit learn import
DanielYang59 1059be9
revert hacky type check changes
DanielYang59 92a4821
bump monty the hard way
DanielYang59 23cbe32
WIP: add draft import time checker
DanielYang59 fe1e32d
add more test modules
DanielYang59 b019517
reduce default average count to 3, it seems very slow
DanielYang59 6bd0bb8
tweak gen ref time logic
DanielYang59 bf57cd0
update ref time
DanielYang59 acd25f9
use perf_counter over time()
DanielYang59 ed48b13
lazy import plotly.figure_factory, reduce 0.2s 10%
DanielYang59 2245483
update ref import time
DanielYang59 f64739a
use standard time format
DanielYang59 5143765
only run on main branch
DanielYang59 77f3f59
use warnings.warn
DanielYang59 b0006c8
use perf_counter_ns
DanielYang59 c337e54
rename measure_import_time_in_ms -> measure_import_time
janosh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.