Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetch_process_wbm_dataset.py unnecessarily loading WBM initial structures from disk #29

Merged
merged 6 commits into from
May 6, 2023
Merged

Fix fetch_process_wbm_dataset.py unnecessarily loading WBM initial structures from disk #29

merged 6 commits into from
May 6, 2023

Conversation

janosh
Copy link
Owner

@janosh janosh commented May 6, 2023

Closes #28.

f50c1a0 add chgnet to running-models deps
b3c7e77 pre-commit autoupdate
226bf4d ruff select PIE,PT
d63a754 fix ruff PT errors
53b849a fix fetch_process_wbm_dataset.py unnecessarily loading WBM initial structures from disk (fixes #28)

@janosh janosh added the data Data loading and processing label May 6, 2023
@janosh janosh enabled auto-merge (squash) May 6, 2023 15:46
@janosh janosh temporarily deployed to github-pages May 6, 2023 15:48 — with GitHub Actions Inactive
@janosh janosh temporarily deployed to github-pages May 6, 2023 15:51 — with GitHub Actions Inactive
@janosh janosh merged commit 5104506 into main May 6, 2023
@janosh janosh deleted the fix-gh-28 branch May 6, 2023 16:02
janosh added a commit that referenced this pull request Jun 20, 2023
@janosh
Fix fetch_process_wbm_dataset.py unnecessarily loading WBM initial …
d7d6bca 
…structures from disk (#29)

* add chgnet to running-models deps

* pre-commit autoupdate

* ruff select PIE,PT

* fix ruff PT errors

* fix fetch_process_wbm_dataset.py unnecessarily loading WBM initial structures from disk (fixes #28)
janosh added a commit that referenced this pull request Jun 20, 2023
@janosh
Fix fetch_process_wbm_dataset.py unnecessarily loading WBM initial …
48a5d28 
…structures from disk (#29)

* add chgnet to running-models deps

* pre-commit autoupdate

* ruff select PIE,PT

* fix ruff PT errors

* fix fetch_process_wbm_dataset.py unnecessarily loading WBM initial structures from disk (fixes #28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
data Data loading and processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetch_process_wbm_dataset.py: data/wbm/2022-10-19-wbm-init-structs.json.bz2 does not exist
1 participant
@janosh