-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MACE readme #113
Merged
Merged
Update MACE readme #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
janosh
reviewed
Jul 14, 2024
models/mace/mace.yml
Outdated
@@ -33,6 +33,7 @@ repo: https://github.com/ACEsuit/mace | |||
doi: https://doi.org/10.48550/arXiv.2401.00096 | |||
paper: https://arxiv.org/abs/2401.00096 | |||
requirements: | |||
mace-torch: 0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.3.0 doesn't exist. https://pypi.org/project/mace-torch/0.3.3 is the earliest release
janosh
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick fix @CompRhys! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted by @YutackPark the mace submission readme had not been updated to reflect the change to use
2023-12-03-mace-128-L1
.As the
multi-gpu
branch has now been merged intomace-torch
slight tweaks were also made to the description of thetrain_mace.py
script which has been left for historical purposes.A link is provided in the readme to the training script for the
2023-12-03-mace-128-L1
model (available here).