Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing CSV with pd.read_json() #43

Closed
pbenner opened this issue Jul 4, 2023 · 3 comments
Closed

Importing CSV with pd.read_json() #43

pbenner opened this issue Jul 4, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@pbenner
Copy link
Collaborator

pbenner commented Jul 4, 2023

The file format of DATA_FILES.mp_energies is now CSV:

df_in = pd.read_json(data_path).set_index(id_col)

Also, the structure column was removed, which is required for training.

@janosh janosh added the bug Something isn't working label Jul 4, 2023
@janosh
Copy link
Owner

janosh commented Jul 4, 2023

Great catch! I found 3 more places with similar problems. Hopefully didn't miss any.

Might have been smarter to store everything as JSON (at the cost of ~50% larger files).

@janosh janosh closed this as completed in ee5b161 Jul 4, 2023
@pbenner
Copy link
Collaborator Author

pbenner commented Jul 4, 2023

Thanks for the quick fix. Now there is two times an assignment to the variable data_files. This line should be deleted:

data_path = DATA_FILES.mp_computed_structure_entries

janosh added a commit that referenced this issue Jul 4, 2023
@janosh
Copy link
Owner

janosh commented Jul 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants