Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location of site-stats.json.gz #33

Closed
pbenner opened this issue May 9, 2023 · 0 comments · Fixed by #34
Closed

Location of site-stats.json.gz #33

pbenner opened this issue May 9, 2023 · 0 comments · Fixed by #34
Labels
data Data loading and processing

Comments

@pbenner
Copy link
Collaborator

pbenner commented May 9, 2023

scripts/compute_struct_fingerprints.py saves result to data/wbm/structure-fingerprints/site-stats.json.gz, while fetch_process_wbm_dataset.py expects data/wbm/site-stats.json.gz. Would be nice to have it directly saved to data/wbm/site-stats.json.gz
@janosh janosh added the data Data loading and processing label May 9, 2023
janosh added a commit that referenced this issue May 9, 2023
@janosh
move out_dir of site-stats.json.gz to data/(wbm|mp) (closes #33)
58f5eb2
@janosh janosh mentioned this issue May 9, 2023
Merged
@janosh janosh closed this as completed in #34 May 9, 2023
janosh added a commit that referenced this issue May 9, 2023
@janosh
Fix KeyError('wyckoff_spglib') in fetch_process_wbm_dataset.py (#34)
9a42546 
* fix Generating Aflow labels raised exception=KeyError('wyckoff_spglib') (closes #32)

* move out_dir of site-stats.json.gz to data/(wbm|mp) (closes #33)
janosh added a commit that referenced this issue Jun 20, 2023
@janosh
Fix KeyError('wyckoff_spglib') in fetch_process_wbm_dataset.py (#34)
78beb45 
* fix Generating Aflow labels raised exception=KeyError('wyckoff_spglib') (closes #32)

* move out_dir of site-stats.json.gz to data/(wbm|mp) (closes #33)
janosh added a commit that referenced this issue Jun 20, 2023
@janosh
Fix KeyError('wyckoff_spglib') in fetch_process_wbm_dataset.py (#34)
ad9d8aa 
* fix Generating Aflow labels raised exception=KeyError('wyckoff_spglib') (closes #32)

* move out_dir of site-stats.json.gz to data/(wbm|mp) (closes #33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data Data loading and processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix KeyError('wyckoff_spglib') in fetch_process_wbm_dataset.py janosh/matbench-discovery
2 participants
@pbenner @janosh