Fix docstrings for int/u64, int/s64 and int/to-number #1544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All credits go to @sogaiu (see this Zulip chat).
The current doc strings for
int/u64
andint/s64
say that these functions only support strings. But as far as I can tell from the diff they always support both numbers and strings, and the test suites cover those cases. I therefore updated the docstrings to indicate that.int/to-number
used to only supportsint32
values but this commit added support for up toJANET_INTMAX_INT64
.This isn't the most ground breaking commit but I was certainly a bit confused about what I can do with these functions when I was dealing with
bxor
ing 64bit integers for Advent of Code.