Add support to Shakapacker

[tagliala]

Shakapacker is the official, actively maintained successor to Webpacker.

Shakapacker v7 changed the spelling of Webpacker to Shakapacker in
the entire project, but still provided backward compatibility for
Webpacker spelling.

v8 dropped the deprecated spelling

This commit also:

• Checks if Shakapacker is defined; if not, it falls back on
  Webpacker.
• Uses the scope resolution operator to resolve at top-level
  scope
• Checks protocol instead of https? because the former is available
  from Webpacker 3 and the latter is not available anymore in
  Shakapacker >= 8

Refs:

• feat!: remove https option shakacode/shakapacker#414
• Remove deprecated webpacker spelling shakacode/shakapacker#429
• Shakapacker v8: reintroduce https? predicate shakacode/shakapacker#486

Close #156

[paypro-leon]

@tagliala Looks good to me. Just need a maintainer to have a look and review.

[tagliala]

Thanks.

I have two successful builds on Shakapacker 7 and 8 at:

• https://github.com/diowa/icare/actions/runs/9256714063
• https://github.com/diowa/icare/actions/runs/9256838181

A proper solution would be to create a new app with Shakapacker 8 and make an integration test here, as per #159, but this would require to fix the test apps repo

[tagliala]

I have a working build against Rails 7.1 / Shakapacker 8: https://github.com/tagliala/inline_svg/actions/runs/9549035858

I've removed the old test against webpacker because of python 2.7 and deprecations.

Please let me know if you need some help or if I should fork

[jamesmartin]

Please let me know if you need some help or if I should fork

Thanks for your work so far. Sorry for the delayed responses, I was away on vacation and then work trips. Let's get CI working properly and then get this merged.

[tagliala]

Hi,

Let's get CI working properly and then get this merged.

I did not invest time in webpacker (it should have been upgraded from v4 to v5 in the rails 6 branch), so this is expected to fail against the CI like it is failing now

#159 is based on this PR and should make the CI pass agains Rails 7.1 / Shakapacker 8

If you are interested, I can make a PR to drop compatibility with legacy Rails and Ruby versions

[jamesmartin]

If you are interested, I can make a PR to drop compatibility with legacy Rails and Ruby versions

Sounds good. Let's do that. 👍

[tagliala]

Friendly bump.

The first steps would be to merge:

• Fix typos #157
• Add Rails 7.2 / Shakapacker 8 test app inline_svg_test_app#24
• Rails 6: Update dependencies inline_svg_test_app#25
• Rails 7: Upgrade to Ruby 3.2 and latest Rails 7.0 inline_svg_test_app#26

Then this PR can be merged because it is not breaking (and it is tested in #159 against Shakapacker)

Then, after a rebase and some changes to the target repo in actions, it will be possible to merge:

• Run GitHub Actions on PRs #159

To have a working CI.

At that point, it would be possible to release a minor version with proper Shakapacker 7+ support.

After the minor release, it would be possible to consider to drop old Ruby and Rails support and go for 2.0. I would entirely drop webpacker support for 2.0

[jamesmartin]

Thanks, this is on my TODO list.

[tagliala]

Thanks, please let me know if you need help and what strategy you decide, everything works for me

[G-Rath]

looking good to me - we're using this gem on nzsl-share, and this change is working well with our Shakapacker v8 upgrade.

(also hi @tagliala! appreciate your work on this 😄)

[jamesmartin]

Thanks for your patience, @tagliala. I'm pushing forward with the plan to properly support Shakapacker v8 moving forward and also to drop support for end-of-life Rails versions in an incoming v2.0 of this gem.