Skip to content

fix: remove any whitespace from SVG tag output #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2023
Merged

fix: remove any whitespace from SVG tag output #150

merged 3 commits into from
Aug 7, 2023

Conversation

fredboyle
Copy link

Addresses issue #149.

Fred Boyle added 2 commits July 31, 2023 15:08
jamesmartin
jamesmartin reviewed Aug 2, 2023
View reviewed changes
Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR. ✨

I had a question about the choice of strip vs. strip!. Thanks for updating the tests. 👍

fix: Tweak per code review
11469cd 
Signed-off-by: Fred Boyle <[email protected]>
jamesmartin
jamesmartin approved these changes Aug 7, 2023
View reviewed changes
Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@jamesmartin jamesmartin merged commit 1a1e2e0 into jamesmartin:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmartin jamesmartin jamesmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredboyle @jamesmartin