Make helpers thread-safe #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested out locally and can't see any regressions. |
|
Thanks again for opening this, @kylefox. ✨ |
|
Released in v1.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112.
tl;dr — using both
inline_svg_tagandinline_svg_pack_tagis not thread-safe because multiple threads could be modifyingInlineSvg.configuration.asset_finder(a global variable) simultaneously. This pull request uses thread-local variables to swap the current asset finder, rather than change the global variable directly.Threads kinda make my head spin, so gotchas & feedback are appreciated 🙏